This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
App/Client/Core: lib + instance work for prelim API #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for better RAII - add related notes - related refactoring
- WIP toward APIs - client and core will process their own configurations - Instance won't (shouldn't) sit in client but will work for now
- Separates client/core Instance/Configuration implementation - Introduces better RAII and preliminary API - Related refactoring + implementing
- If Exception class isn't member initialized before a calling ctor function try-block throws, string member manipulation results in segfault. As such, simply use locals. - Fixes formatting if dispatch message is missing
- namespace cleanup for Daemon/Client/Core/Configuration only - Uses list initilization for client tunnel counters - Instance logging clarifications - clang-format check-in
- core Instance no longer relies on CLI (or any) args - ctor now logs args (if applicable)
See TODOs for known issues.
anonimal
added a commit
that referenced
this pull request
Nov 2, 2017
bd615a5 Util: add kovri as instance PoC (for prelim API) (anonimal) 0ba4882 Core: set default param for Instance/Configuration (anonimal) ae1370b Core: fix reporting wrong Instance port number (anonimal) 9a3ac39 Client/Core: const + ref correctness for Instance/Configuration (anonimal) fab31fb Client: use Exception dispatcher for Configuration (anonimal) ee2ae90 Kovri: namespace cleanup + style check-in + misc (anonimal) 1cde1ab Exception: rewrite dispatcher + fix segfault (anonimal) ae52d6e Kovri: create core Instance/Configuration + rewrite client Instance (anonimal) e212dcd App: decouple Instance/Configuration, move to client (anonimal) 18f50af App: configure Instance upon construction (anonimal) de8ef03 App: use exception dispatcher for config/init (anonimal) a522cb1 App: separate Instance start/stop from daemon singleton (anonimal)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
By submitting this pull-request, I confirm the following: