Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: miniupnpc: remove submodule, add to depends, update to 2.2.7 #9273

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

build: miniupnpc: remove submodule, add to depends, update to 2.2.7 #9273

wants to merge 1 commit into from

Conversation

tobtoht
Copy link
Collaborator

@tobtoht tobtoht commented Mar 31, 2024 •
edited
Loading

Supply chain security checklist:

  • The source tarball is GPG signed
  • The source tarball does not contain binaries or archives
  • The source tarball does not contain auto-generated scripts
  • The source tarball does not differ from git source in a meaningful way
  • The package has not changed ownership since the last update (2.2.1)

Why?

  • Keep release dependencies in one place (depends)
  • Allows us to patch the package without forking the repository
  • For development builds: miniupnpc is packaged for all relevant distributions

@0xFFFC0000
Copy link
Collaborator

We can only merge this or #9367

@tobtoht tobtoht mentioned this pull request Dec 18, 2024
Open
@tobtoht tobtoht mentioned this pull request Jan 5, 2025
Open
@tobtoht tobtoht force-pushed the depends_miniupnpc branch from 91faf9f to 2af346d Compare January 6, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobtoht @0xFFFC0000 @selsta