Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends: unbound: update to 1.22.0 #9642

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobtoht
Copy link
Collaborator

@tobtoht tobtoht commented Dec 24, 2024

Supply chain security

  • ☑ The tarball was signed with the same GPG key as the previous update (1.19.1)
    • EDFAA3F2CA4E6EB05681AF8E9F6F1C2D7E045F8D
  • ☑ The repository has not changed ownership since the previous update
  • ☑ The git tag was GPG signed by the maintainer
  • ☑ Blobs were removed from the source in preprocess_cmds
  • ☑ The tarball is used by 5 or more distributions.
  • ⚠ The source archive does not match the contents of the git repo. The following files remain after cleanup:
util/configlexer.c
util/configparser.c
util/configparser.h

This was referenced Jan 2, 2025
@tobtoht tobtoht force-pushed the depends_unbound branch 2 times, most recently from dc08d0e to de4bf9a Compare January 17, 2025 20:37
@tobtoht tobtoht marked this pull request as ready for review January 18, 2025 03:04
define $(package)_preprocess_cmds
rm configure~ doc/*.odp doc/*.pdf contrib/*.tar.gz contrib/*.tar.bz2 &&\

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could make this a little easier to read with alternate shell syntax:
rm configure~ doc/*.{odp,pdf} contrib/*.tar.{gz,bz2} ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brace expansion isn't defined in POSIX. I didn't know this until I found out that:

In depends CI, which runs on Ubuntu 20.04, the SHELL environment variable isn't set by default causing make to fall back to /bin/sh, resulting in an error on this line. On 20.04 /bin/sh is Dash which tries to be POSIX compliant and does not support brace expansion.

For portability reasons, I have reverted back to the less readable syntax.

@iamamyth
Copy link

⚠ The source archive does not match the contents of the git repo.

I did a side-by-side compare and the mismatch owes to makedist.sh. In addition to replacing placeholder variables in various files, the distribution process auto-generates the lexer and parser files using flex and bison/yacc, respectively.

Copy link

@iamamyth iamamyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor trivial style suggestion, but this looks OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants