-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depends: unbound: update to 1.22.0 #9642
base: master
Are you sure you want to change the base?
Conversation
dc08d0e
to
de4bf9a
Compare
define $(package)_preprocess_cmds | ||
rm configure~ doc/*.odp doc/*.pdf contrib/*.tar.gz contrib/*.tar.bz2 &&\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could make this a little easier to read with alternate shell syntax:
rm configure~ doc/*.{odp,pdf} contrib/*.tar.{gz,bz2} ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brace expansion isn't defined in POSIX. I didn't know this until I found out that:
In depends
CI, which runs on Ubuntu 20.04, the SHELL
environment variable isn't set by default causing make
to fall back to /bin/sh
, resulting in an error on this line. On 20.04 /bin/sh
is Dash which tries to be POSIX compliant and does not support brace expansion.
For portability reasons, I have reverted back to the less readable syntax.
I did a side-by-side compare and the mismatch owes to makedist.sh. In addition to replacing placeholder variables in various files, the distribution process auto-generates the lexer and parser files using flex and bison/yacc, respectively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor trivial style suggestion, but this looks OK.
de4bf9a
to
cd696e8
Compare
cd696e8
to
f150ff1
Compare
Supply chain security
EDFAA3F2CA4E6EB05681AF8E9F6F1C2D7E045F8D
preprocess_cmds