add do_not_relay option to sweep_single ... #9698
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SNeedlewoods
force-pushed
the
x_add_do_not_relay_option_to_sweep_single
branch
from
d7ee3ad to
86144f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and submit_multisig_main methods in simplewallet.
It seems when the PR that added
sweep_single()(see here) was made, the PR forcommit_or_save()(see here) wasn't done yet and that's why sweep_single still callsm_wallet->commit_tx()(src) which does not have thedo_not_relayoption, which was added on the second PR mentioned.For the
submit_multisig_main()I have to admit I didn't investigate and don't have an argument, besides I assume that's how it should be done.