functional tests: fix race in restore wallet refresh #9720
Merged
+23
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to confirm, this was purely a test issue and this case can not happen inside a real wallet? |
|
Yep, correct |
iamamyth
approved these changes
Jan 23, 2025
iamamyth
reviewed
Jan 23, 2025
tests/functional_tests/transfer.py
Outdated
| @@ -57,6 +57,15 @@ def diff_incoming_transfers(actual_transfers, expected_transfers): | |||
| # wallet2 m_transfers container is ordered and order should be the same across rescans | |||
| diff_transfers(actual_transfers, expected_transfers, ignore_order = False) | |||
|
|
|||
| def restore_wallet(wallet, seed, restore_height = 0, filename = '', password = '', ): | |||
There was a problem hiding this comment.
The trailing , after the last param, though allowed, seems to break with the style elsewhere in this file, as well as python convention.
|
The style comment doesn't impact approval (I saw the issue prior to signing off), as every part of the code style in these tests violates most linter rule sets, so one extra line doesn't matter. |
j-berman
force-pushed
the
scan-tx-test-fix
branch
from
618b23d to
3b64d1f
Compare
selsta
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to disable auto refresh before restoring the wallet, so refresh doesn't run in the idle loop upon restoring.
Fixes this test failure highlighted by @tobtoht (apologies for missing it).