MF Test Platform Init #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littlemight
force-pushed
the
f/fang-challenge
branch
from
6dc62c6 to
df246f5
Compare
yuyuvn
approved these changes
Aug 2, 2022
yuyuvn
reviewed
Aug 2, 2022
lib/rspecq.rb
Outdated
| @@ -5,12 +5,13 @@ module RSpecQ | |||
| # If a worker haven't executed an example for more than WORKER_LIVENESS_SEC | |||
| # seconds, it is considered dead and its reserved work will be put back | |||
| # to the queue to be picked up by another worker. | |||
| WORKER_LIVENESS_SEC = 60.0 | |||
| WORKER_LIVENESS_SEC = 300.0 # 5 mins, leeway for an example that runs for several minutes | |||
There was a problem hiding this comment.
it would be better if we can config it somewhere instead of hard code
yuyuvn
reviewed
Aug 2, 2022
lib/rspecq/worker.rb
Outdated
| @@ -180,7 +199,28 @@ def try_publish_queue!(queue) | |||
|
|
|||
| if slow_files.any? | |||
| jobs.concat(files_to_run - slow_files) | |||
| jobs.concat(files_to_example_ids(slow_files)) | |||
| total_worker = Integer(ENV["CIRCLE_NODE_TOTAL"] || 420) # TODO: parse from flag | |||
There was a problem hiding this comment.
we should use another env var so we can run not only in circleci but other CI
yuyuvn
reviewed
Aug 2, 2022
yuyuvn
reviewed
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related document: https://moneyforward.kibe.la/notes/224857
In this PR:
WORKER_LIVENESS_SEC