Update README #87
Merged
Update README #87
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGasper
requested changes
Feb 11, 2025
README.md
Outdated
| @@ -14,6 +14,11 @@ _If verifying a migration done via [mongosync](https://www.mongodb.com/docs/clus | |||
|
|
|||
| _Assumes no port set, default port for operation webserver is 27020_ | |||
|
|
|||
| # Recommendations | |||
|
|
|||
| Users should use a different cluster for storing migration verification metadata. If the user must use the destination cluster, | |||
There was a problem hiding this comment.
Also, the user may be the reader of this document; thus, describing what “the user” should do could cause confusion.
There was a problem hiding this comment.
Suggested:
# Verifier Metadata Considerations
migration-verifier needs a database to store its state. This database SHOULD be on its own cluster.
The verifier _can_ instead store its metadata on the destination cluster. This can severely degrade performance, though. It also requires either disabling mongosync’s destination write blocking or giving the `bypassWriteBlockingMode` to the verifier’s `--metaURI` user.
There was a problem hiding this comment.
yup fair point. Also, I asked Jian to put up this PR because I'm still lacking push permissions for some reason (and I didn't want to deal with all the permission stuff yet for a readme update 😅 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update to README per @ajayvijayakumar123's request.