docsp-27681 - move example classes #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
requested changes
Dec 19, 2023
source/usage-examples.txt
Outdated
Comment on lines
74
to
75
| The usage examples in this section use the following ``Restaurant``, ``Address``, and | ||
| ``GradeEntry`` classes as models: |
There was a problem hiding this comment.
S: in this introduction, mention the db/collection as well, to provide some context. Perhaps something like:
Suggested change
| The usage examples in this section use the following ``Restaurant``, ``Address``, and | |
| ``GradeEntry`` classes as models: | |
| The usage examples in this section demonstrate how to perform operatons on documents in the | |
| ``restaurants`` collection. The examples use the following ``Restaurant``, ``Address``, and | |
| ``GradeEntry`` classes to model the data in this collection: |
Or, you can add this information to the first sentence earlier in this file that says "These examples use the
sample datasets provided by Atlas." because this suggests that the examples use more than one collection, but its seems like they all use the restaurants collection.
There was a problem hiding this comment.
I think the first option still suggests that the restaurants collection is part of the Atlas sample datasets, so I went with that
source/usage-examples/deleteMany.txt
Outdated
Comment on lines
18
to
19
| Example | ||
| ------- |
rustagir
approved these changes
Dec 20, 2023
mongoKart
added a commit
that referenced
this pull request
Dec 20, 2023
(cherry picked from commit 9ec1bae)
mongoKart
added a commit
that referenced
this pull request
Dec 20, 2023
(cherry picked from commit 9ec1bae)
mongoKart
added a commit
that referenced
this pull request
Dec 20, 2023
(cherry picked from commit 9ec1bae)
mongoKart
added a commit
that referenced
this pull request
Dec 20, 2023
(cherry picked from commit 9ec1bae)
mongoKart
added a commit
that referenced
this pull request
Dec 20, 2023
(cherry picked from commit 9ec1bae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-27681
Staging - https://preview-mongodbmongokart.gatsbyjs.io/csharp/docsp-27681-move-sample-classes/usage-examples/
Self-Review Checklist