[C#] Code Snippet for Atlas Search Autocomplete doesn't work #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
requested changes
Mar 4, 2024
source/fundamentals/atlas-search.txt
Outdated
Comment on lines
110
to
111
| If the field you are searching has a search index, it must be included in your ``Autocomplete`` call: | ||
| ``Search.Autocomplete(g => g.Make, "Gib"), indexName: <make_search_index>)`` |
There was a problem hiding this comment.
Q: Is this issue unique to the Autocomplete() Search method? Can you please check with the Pm to verify if all of the code examples used on this page need to include the search index name?
There was a problem hiding this comment.
According to the PM, yes, this is specific to Autocomplete and he did test all the methods except the Geo ones.
There was a problem hiding this comment.
After reading the code example, I feel like the actual code example used in this section should be updated as well. The note could clarify that compared to the other examples, where the default index is used in the absence of the index name, this example explicitly requires the index name.
rustagir
approved these changes
Mar 15, 2024
source/fundamentals/atlas-search.txt
Outdated
| @@ -106,6 +106,10 @@ collection using the string "Gib" in the ``make`` field. | |||
| :language: csharp | |||
| :dedent: | |||
|
|
|||
| .. note:: | |||
|
|
|||
| If the field you are searching has a search index, it must be included in your ``Autocomplete`` call. If a search index does not exist, the default index is used. | |||
There was a problem hiding this comment.
Suggested change
| If the field you are searching has a search index, it must be included in your ``Autocomplete`` call. If a search index does not exist, the default index is used. | |
| If the field you are searching on is indexed by a search index, you must pass the index name to the | |
| ``Autocomplete`` call. If a search index does not exist, the search uses the default index. |
rachel-mack
added a commit
to rachel-mack/docs-csharp
that referenced
this pull request
Mar 19, 2024
…#177) * add note about search index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-37267
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/csharp/docsworker-xlarge/DOCSP-37267/fundamentals/atlas-search/#std-label-csharp-atlas-search
Self-Review Checklist