DOCSP-39027: Add CMAP diagram to FAQ page #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
requested changes
May 8, 2024
There was a problem hiding this comment.
S: could a different image be used for the client application and mongoclient? i feel like the mongoclient could be the person figure and the application should be the C#/.NET logo or something like that
source/faq.txt
Outdated
Comment on lines
47
to
48
| until a connection becomes available. The following diagram illustrates a high-level view | ||
| of the ``MongoClient``'s connection pool functionality: |
There was a problem hiding this comment.
Suggested change
| until a connection becomes available. The following diagram illustrates a high-level view | |
| of the ``MongoClient``'s connection pool functionality: | |
| until a connection becomes available. The following diagram illustrates a high-level view | |
| of how the ``MongoClient`` manages a connection pool: |
rustagir
reviewed
May 8, 2024
There was a problem hiding this comment.
S: could you also add some text between mongoclient and connection pool?
There was a problem hiding this comment.
Maybe "controls" or "deploys" or "maintains"
rustagir
approved these changes
May 8, 2024
mcmorisi
added a commit
that referenced
this pull request
May 9, 2024
(cherry picked from commit 9c5250f)
mcmorisi
added a commit
that referenced
this pull request
May 9, 2024
(cherry picked from commit 9c5250f)
mcmorisi
added a commit
that referenced
this pull request
May 9, 2024
(cherry picked from commit 9c5250f)
mcmorisi
added a commit
that referenced
this pull request
May 9, 2024
(cherry picked from commit 9c5250f)
mcmorisi
added a commit
that referenced
this pull request
May 9, 2024
(cherry picked from commit 9c5250f)
mcmorisi
added a commit
that referenced
this pull request
May 9, 2024
(cherry picked from commit 9c5250f)
mcmorisi
added a commit
that referenced
this pull request
May 9, 2024
(cherry picked from commit 9c5250f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
Adding a simple illustrative CMAP diagram to FAQ page.
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-39027
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/csharp/DOCSP-39027/faq/
Self-Review Checklist