Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-37469: Add transactions page #199

Merged
merged 5 commits into from
May 28, 2024

Conversation

mcmorisi
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - <DOCSP-37469>
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/csharp/DOCSP-37469-transactions-v2/fundamentals/transactions/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@mcmorisi mcmorisi requested a review from a team May 22, 2024 20:30
Copy link
Collaborator

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with final comments to clean up some sentences!

source/fundamentals/transactions.txt Outdated Show resolved Hide resolved
source/fundamentals/transactions.txt Outdated Show resolved Hide resolved
source/fundamentals/transactions.txt Outdated Show resolved Hide resolved
source/fundamentals/transactions.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, added few comments.

source/fundamentals/transactions.txt Show resolved Hide resolved
source/fundamentals/transactions.txt Show resolved Hide resolved
source/includes/fundamentals/code-examples/Transaction.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

// end-transaction
}

public static void Setup(IMongoDatabase database) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allman style braces.

@mcmorisi mcmorisi merged commit 8553e6d into mongodb:master May 28, 2024
2 checks passed
mcmorisi added a commit that referenced this pull request May 28, 2024
mcmorisi added a commit that referenced this pull request May 28, 2024
mcmorisi added a commit that referenced this pull request May 28, 2024
mcmorisi added a commit that referenced this pull request May 28, 2024
mcmorisi added a commit that referenced this pull request May 28, 2024
mcmorisi added a commit that referenced this pull request May 28, 2024
mcmorisi added a commit that referenced this pull request May 28, 2024
@mcmorisi mcmorisi deleted the DOCSP-37469-transactions-v2 branch May 28, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants