Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-46455 Too Short Title: LINQ #473

Merged
merged 4 commits into from
Feb 14, 2025
Merged

DOCSP-46455 Too Short Title: LINQ #473

merged 4 commits into from
Feb 14, 2025

Conversation

lindseymoore
Copy link
Collaborator

@lindseymoore lindseymoore commented Feb 12, 2025 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46455

Staging Links

  • fundamentals/linq

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify Netlify
    Copy link

    netlify bot commented Feb 12, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit 356f904
    🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/67af6d898232860007e29873
    😎 Deploy Preview https://deploy-preview-473--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    mongoKart
    mongoKart requested changes Feb 12, 2025
    View reviewed changes
    source/fundamentals/linq.txt Outdated
    LINQ
    ====
    ==========================================
    Query with LINQ and Aggregation Operations
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This title makes it sound like the page covers two ways to query: LINQ and aggregation operations. LINQ is really just an alternative syntax for running queries--one which happens to use aggregation operations under the hood. Is something like 'Query Data with LINQ' too short?

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Yes it's too short unfortunately :(

    mongoKart
    mongoKart requested changes Feb 14, 2025
    View reviewed changes
    source/fundamentals/linq.txt Outdated
    LINQ
    ====
    ================================
    Language Integrated Query (LINQ)
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    good thought, but it's inconsistent with the style guide. how about:

    Suggested change
    Language Integrated Query (LINQ)
    LINQ Syntax for Aggregation Operations

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks for that style guide link; yes LGTM!

    mongoKart
    mongoKart approved these changes Feb 14, 2025
    View reviewed changes
    Copy link
    Collaborator

    @mongoKart mongoKart left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @lindseymoore lindseymoore merged commit 843ab98 into mongodb:master Feb 14, 2025
    17 checks passed
    github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
    @lindseymoore @github-actions
    DOCSP-46455 Too Short Title: LINQ (#473)
    a0a4c95 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)
    @github-actions github-actions bot mentioned this pull request Feb 14, 2025
    Merged
    github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
    @lindseymoore @github-actions
    DOCSP-46455 Too Short Title: LINQ (#473)
    a247984 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)
    @github-actions github-actions bot mentioned this pull request Feb 14, 2025
    Merged
    github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
    @lindseymoore @github-actions
    DOCSP-46455 Too Short Title: LINQ (#473)
    38763a7 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)
    @github-actions github-actions bot mentioned this pull request Feb 14, 2025
    Merged
    github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
    @lindseymoore @github-actions
    DOCSP-46455 Too Short Title: LINQ (#473)
    6d4f3b4 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)
    github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
    @lindseymoore @github-actions
    DOCSP-46455 Too Short Title: LINQ (#473)
    c842721 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)
    This was referenced Feb 14, 2025
    Merged
    Merged
    github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
    @lindseymoore @github-actions
    DOCSP-46455 Too Short Title: LINQ (#473)
    7eaff7b 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)
    @github-actions github-actions bot mentioned this pull request Feb 14, 2025
    Merged
    github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
    @lindseymoore @github-actions
    DOCSP-46455 Too Short Title: LINQ (#473)
    00c57d5 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)
    @github-actions github-actions bot mentioned this pull request Feb 14, 2025
    Merged
    github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
    @lindseymoore @github-actions
    DOCSP-46455 Too Short Title: LINQ (#473)
    69f43ce 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)
    github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
    @lindseymoore @github-actions
    DOCSP-46455 Too Short Title: LINQ (#473)
    1e49b41 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)
    This was referenced Feb 14, 2025
    Merged
    Merged
    github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
    @lindseymoore @github-actions
    DOCSP-46455 Too Short Title: LINQ (#473)
    aefc359 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)
    @github-actions github-actions bot mentioned this pull request Feb 14, 2025
    Merged
    github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
    @lindseymoore @github-actions
    DOCSP-46455 Too Short Title: LINQ (#473)
    a217aba 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)
    @github-actions github-actions bot mentioned this pull request Feb 14, 2025
    Merged
    lindseymoore added a commit that referenced this pull request Feb 14, 2025
    @github-actions @lindseymoore
    DOCSP-46455 Too Short Title: LINQ (#473) (#496)
    0559fdb 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)

Co-authored-by: lindseymoore <[email protected]>
    lindseymoore added a commit that referenced this pull request Feb 14, 2025
    @github-actions @lindseymoore
    DOCSP-46455 Too Short Title: LINQ (#473) (#495)
    784d7b4 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)

Co-authored-by: lindseymoore <[email protected]>
    lindseymoore added a commit that referenced this pull request Feb 14, 2025
    @github-actions @lindseymoore
    DOCSP-46455 Too Short Title: LINQ (#473) (#494)
    ccac123 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)

Co-authored-by: lindseymoore <[email protected]>
    lindseymoore added a commit that referenced this pull request Feb 14, 2025
    @github-actions @lindseymoore
    DOCSP-46455 Too Short Title: LINQ (#473) (#493)
    db0b21b 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)

Co-authored-by: lindseymoore <[email protected]>
    lindseymoore added a commit that referenced this pull request Feb 14, 2025
    @github-actions @lindseymoore
    DOCSP-46455 Too Short Title: LINQ (#473) (#492)
    af7fbe0 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)

Co-authored-by: lindseymoore <[email protected]>
    lindseymoore added a commit that referenced this pull request Feb 14, 2025
    @github-actions @lindseymoore
    DOCSP-46455 Too Short Title: LINQ (#473) (#491)
    72522a1 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)

Co-authored-by: lindseymoore <[email protected]>
    lindseymoore added a commit that referenced this pull request Feb 14, 2025
    @github-actions @lindseymoore
    DOCSP-46455 Too Short Title: LINQ (#473) (#490)
    628cfb1 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)

Co-authored-by: lindseymoore <[email protected]>
    lindseymoore added a commit that referenced this pull request Feb 14, 2025
    @github-actions @lindseymoore
    DOCSP-46455 Too Short Title: LINQ (#473) (#489)
    ec5a825 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)

Co-authored-by: lindseymoore <[email protected]>
    lindseymoore added a commit that referenced this pull request Feb 14, 2025
    @github-actions @lindseymoore
    DOCSP-46455 Too Short Title: LINQ (#473) (#488)
    82716ed 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)

Co-authored-by: lindseymoore <[email protected]>
    lindseymoore added a commit that referenced this pull request Feb 14, 2025
    @github-actions @lindseymoore
    DOCSP-46455 Too Short Title: LINQ (#473) (#487)
    0c5b855 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)

Co-authored-by: lindseymoore <[email protected]>
    lindseymoore added a commit that referenced this pull request Feb 14, 2025
    @github-actions @lindseymoore
    DOCSP-46455 Too Short Title: LINQ (#473) (#486)
    d487b38 
    * DOCSP-46455 Too Short Title: LINQ

* edit

* MW edit

* MW edit

(cherry picked from commit 843ab98)

Co-authored-by: lindseymoore <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @mongoKart mongoKart mongoKart approved these changes

    Assignees
    No one assigned
    Labels
    backport v2.22 backport v2.23 backport v2.24 backport v2.25 backport v2.26 backport v2.27 backport v2.28 backport v2.29 backport v2.30 backport v3.0 backport v3.1
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @lindseymoore @mongoKart