Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-44317: Adding Support for Free-threaded Python #121

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

mayaraman19
Copy link
Collaborator

@mayaraman19 mayaraman19 commented Nov 6, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44317
Staging - https://deploy-preview-121--docs-pymongo.netlify.app/whats-new/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for docs-pymongo ready!

Name Link
🔨 Latest commit 369b172
🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/672be45160a3dd00083b4f78
😎 Deploy Preview https://deploy-preview-121--docs-pymongo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + suggestion!

Comment on lines 37 to 38
- Adds support for `free-threaded CPython <https://docs.python.org/3/howto/free-threading-python.html>`__
when running Python v3.13+.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: instead of hyperlinking the text, I'd add a brief description of where this link is going

Suggested change
- Adds support for `free-threaded CPython <https://docs.python.org/3/howto/free-threading-python.html>`__
when running Python v3.13+.
- Adds support for free-threaded CPython when running Python v3.13+. For more information about free threading, see the `Python documentation <https://docs.python.org/3/howto/free-threading-python.html>`__.

@mayaraman19 mayaraman19 merged commit 88046dd into master Nov 6, 2024
6 checks passed
@mayaraman19 mayaraman19 deleted the DOCSP-44317-free-threaded branch November 6, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants