chore(ci): address codeql issues in gha workflows #128
+33
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
no release notes
nirinchev
added
the
no-title-validation
github-actions
bot
added
no release notes
Coverage Report
|
|
🤖 Benchmark Comparison for
|
kmruiz
requested changes
Jan 23, 2025
| @@ -3,6 +3,10 @@ on: | |||
| pull_request: | |||
| types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled] | |||
|
|
|||
| permissions: | |||
| contents: read | |||
| pull-requests: write | |||
There was a problem hiding this comment.
Why are we adding additional permissions to this workflow? We don't need them for checking the changelog and blocking a PR right?
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: read |
There was a problem hiding this comment.
Same thing here, we don't want workflows to have additional permissions unless they are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses most issues reported by codeql. The remaining ones are related to using
mongodb-js/devtools-shared/actions/setup-bot-token@maininstead of pinning to a commit. I feel that this should be treated as a first-party action and be exempt from requiring commit pinning, but am open to be convinced otherwise