Changes Storybook name for Typography Live Example to properly render on .design #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 62433ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 55 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
tsck
approved these changes
Feb 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
stephl3
reviewed
Feb 6, 2025
| @@ -147,8 +147,9 @@ const meta: StoryMetaType<typeof TypographyDemoComponent> = { | |||
| }; | |||
| export default meta; | |||
|
|
|||
| export const AllTypography: StoryType<typeof TypographyDemoComponent> = | |||
| TypographyDemoComponent.bind({}); | |||
| export const AllTypography: StoryType<typeof LiveExample> = LiveExample.bind( | |||
There was a problem hiding this comment.
isn't this the one you'd have to change to LiveExample ?
There was a problem hiding this comment.
cleaned this up - take a look
stephl3
approved these changes
Feb 6, 2025
Comment on lines
-153
to
-158
| baseFontSize: { | ||
| ...storybookArgTypes.baseFontSize, | ||
| description: | ||
| 'Storybook prop only. This font size is passed into the LeafygreenProvider.', | ||
| }, | ||
| darkMode: storybookArgTypes.darkMode, |
There was a problem hiding this comment.
axing this whole story removes the storybook control docs for these props. if we care about leaving them as part of the story, we should rename this story LiveExample and leave TypographyDemoComponent as-is
There was a problem hiding this comment.
No it doesnt, take a look at the live example
There was a problem hiding this comment.
The description is different on main: https://642700aa3e49e32bdbf0b0fc-sicyggiuaw.chromatic.com/?path=/story/components-typography--all-typography
vs this branch: https://642700aa3e49e32bdbf0b0fc-ptjdzyvgni.chromatic.com/?path=/story/components-typography--live-example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changesFor new components
🧪 How to test changes