LG-4830: add DrawerTabs component #2720
Merged
+346
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Type |
|---|---|
| @leafygreen-ui/drawer | Major |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
stephl3
force-pushed
the
steph/dr-tabs
branch
from
6380b80 to
afe67e6
Compare
stephl3
force-pushed
the
LG-4806-drawer
branch
from
55339e8 to
50b5b59
Compare
stephl3
force-pushed
the
steph/dr-tabs
branch
from
afe67e6 to
821c407
Compare
|
Size Change: +2.39 kB (+0.17%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
stephl3
force-pushed
the
steph/dr-tabs
branch
from
821c407 to
6039866
Compare
shaneeza
reviewed
Feb 12, 2025
| setHasShadowTop(scrollContainerEl.scrollTop > 0); | ||
| }; | ||
|
|
||
| scrollContainerEl.addEventListener('scroll', handleScroll); |
There was a problem hiding this comment.
nit: while working on table, I found that IntersectionObserver was helpful in avoiding frequent scroll event handling. Maybe it could be beneficial here?
There was a problem hiding this comment.
thanks for the suggestion! I was able to implement something similar here and cut out the additions to the tabs package :)
tsck
reviewed
Feb 13, 2025
Comment on lines
30
to
32
| const handleScroll = () => { | ||
| setHasShadowTop(scrollContainerEl.scrollTop > 0); | ||
| }; |
There was a problem hiding this comment.
Nit 1: Since scrollContainerRef is accessible outside of the useEffect callback, this function doesn't need to be recreated on every call and can be moved to the outer scope and only initialized once on mount using useCallback. It's so small I'm not worried about it so definitely feel free to leave as is if you think it improves readability.
Nit 2: (I think @shaneeza's suggestion would solve this in a better way, but will still leave this in case you don't go in that direction) Currently this function is going to fire quite a bit on scroll. It's sometimes advisable to debounce scroll handlers to minimize this a bit.
There was a problem hiding this comment.
updated to using useInView which uses the intersection observer under the hood
stephl3
force-pushed
the
steph/dr-tabs
branch
from
829b2b2 to
35a239c
Compare
stephl3
force-pushed
the
steph/dr-tabs
branch
from
35a239c to
39141ff
Compare
tsck
approved these changes
Feb 14, 2025
shaneeza
reviewed
Feb 14, 2025
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
tabListContainerRefandtabPanelsContainerRefprops toTabscomponentDrawerTabscomponent🎟 Jira ticket: LG-4830
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes
Drawer/ScrollstoryDrawer/WithTabsstory