Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-5047 Improve testing of publish workflows and fix integration tests #943

Merged
merged 15 commits into from
Feb 1, 2025

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Jan 27, 2025

The integ test is now passing, but this needs to be in draft until mongodb-labs/drivers-evergreen-tools#586 is merged and we update the git checkout here.

@blink1073 blink1073 requested a review from Jibola January 27, 2025 16:19
.github/workflows/release-python.yml Dismissed Show dismissed Hide dismissed
@blink1073 blink1073 changed the title PYTHON-5047 Improve testing of publish workflows PYTHON-5047 Improve testing of publish workflows and fix integration tests Jan 30, 2025
@blink1073 blink1073 requested a review from a team as a code owner January 30, 2025 03:47
@blink1073 blink1073 marked this pull request as draft January 30, 2025 03:48
Copy link
Contributor

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch needs to be reverted in integ-setup.sh

@@ -28,7 +28,7 @@ MONGOCRYPT_DIR: "$MONGOCRYPT_DIR"
EOT

# Set up drivers-tools with a .env file.
git clone https://github.com/mongodb-labs/drivers-evergreen-tools.git ${DRIVERS_TOOLS}
git clone --branch DRIVERS-3032-fix-crypt_shared_loc https://github.com/blink1073/drivers-evergreen-tools.git ${DRIVERS_TOOLS}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the PR for drivers-evergreen-tools is merged, this will have to be reverted.

@caseyclements caseyclements self-requested a review February 1, 2025 14:20
@caseyclements caseyclements marked this pull request as ready for review February 1, 2025 14:21
Copy link
Contributor

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now that we've merged drivers-evergreen-tools/pull/588

@caseyclements caseyclements merged commit ca98747 into mongodb:master Feb 1, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants