Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-275155: [AtlasCLI] Update Go SDK: Add support for pinned versions #3286

Merged
merged 2 commits into from
Sep 25, 2024
Merged

CLOUDP-275155: [AtlasCLI] Update Go SDK: Add support for pinned versions #3286

merged 2 commits into from
Sep 25, 2024

Conversation

jeroenvervaeke
Copy link
Collaborator

Proposed changes

Fixed update-sdk.sh to support pinned version:

  • Added --rewrite flag to gomajor: Add --rewrite flag to get command icholy/gomajor#36 to allow us to only update a specific version of the SDK
  • Save the current version of the SDK in .atlas-sdk-version
  • Replace the SDK version in:
    • Code
    • library_owners.json
    • .golanci.yml

Jira ticket: CLOUDP-275155

@jeroenvervaeke jeroenvervaeke requested a review from a team as a code owner September 25, 2024 16:36
@jeroenvervaeke jeroenvervaeke enabled auto-merge (squash) September 25, 2024 16:46
@jeroenvervaeke jeroenvervaeke merged commit 04b1d05 into master Sep 25, 2024
18 of 19 checks passed
@jeroenvervaeke jeroenvervaeke deleted the CLOUDP-275155 branch September 25, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmenezes fmenezes fmenezes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeroenvervaeke @fmenezes