MONGOID-5836 Don't repeat callbacks for embedded grandchildren. #5933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grandchildren are already accounted for when this is invoked, because if called when callbacks are cascading, the input is the full list of all children and grandchildren. Processing grandchildren recursively here causes them to be processed twice.
jamis
requested review from
comandeo-mongo
and removed request for
comandeo-mongo
comandeo-mongo
approved these changes
Jan 15, 2025
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Jan 15, 2025
…odb#5933) * MONGOID-5836 don't explicitly process grandchildren Grandchildren are already accounted for when this is invoked, because if called when callbacks are cascading, the input is the full list of all children and grandchildren. Processing grandchildren recursively here causes them to be processed twice. * specify python version to address failing mongo-orchestration * make sure we don't break update callbacks
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Jan 15, 2025
…odb#5933) * MONGOID-5836 don't explicitly process grandchildren Grandchildren are already accounted for when this is invoked, because if called when callbacks are cascading, the input is the full list of all children and grandchildren. Processing grandchildren recursively here causes them to be processed twice. * specify python version to address failing mongo-orchestration * make sure we don't break update callbacks
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Jan 15, 2025
…odb#5933) * MONGOID-5836 don't explicitly process grandchildren Grandchildren are already accounted for when this is invoked, because if called when callbacks are cascading, the input is the full list of all children and grandchildren. Processing grandchildren recursively here causes them to be processed twice. * specify python version to address failing mongo-orchestration * make sure we don't break update callbacks
jamis
added a commit
that referenced
this pull request
Jan 24, 2025
…ort to 8.1-stable) (#5936) * MONGOID-5836 Don't repeat callbacks for embedded grandchildren. (#5933) * MONGOID-5836 don't explicitly process grandchildren Grandchildren are already accounted for when this is invoked, because if called when callbacks are cascading, the input is the full list of all children and grandchildren. Processing grandchildren recursively here causes them to be processed twice. * specify python version to address failing mongo-orchestration * make sure we don't break update callbacks * prevent duplicate callbacks for these tests
jamis
added a commit
that referenced
this pull request
Jan 24, 2025
… (#5935) * MONGOID-5836 don't explicitly process grandchildren Grandchildren are already accounted for when this is invoked, because if called when callbacks are cascading, the input is the full list of all children and grandchildren. Processing grandchildren recursively here causes them to be processed twice. * specify python version to address failing mongo-orchestration * make sure we don't break update callbacks
jamis
added a commit
that referenced
this pull request
Jan 24, 2025
…port to 8.0-stable) (#5937) * MONGOID-5836 Don't repeat callbacks for embedded grandchildren. (#5933) * MONGOID-5836 don't explicitly process grandchildren Grandchildren are already accounted for when this is invoked, because if called when callbacks are cascading, the input is the full list of all children and grandchildren. Processing grandchildren recursively here causes them to be processed twice. * specify python version to address failing mongo-orchestration * make sure we don't break update callbacks * don't recursively process children here the list of children already includes all descendants * MONGOID-5542 Prevent multiple calls of embedded docs callbacks (#5621) (#5626) * Add test * Fix double callback call * Change test that expects the old behavior * Add config option * Flip the flag --------- Co-authored-by: Dmitry Rybakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the
beforecallbacks on embedded children, the grandchildren were being explicitly processed (when callbacks were cascading). However, the input is already the full list of all children and grandchildren. Processing the grandchildren again results in duplicate callbacks being invoked.