DOP-5199: Team wide Netlfiy env variables #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#47) * changes * cleaing up code * spelling * print * adding check * adding catch * cleanign up logs * adding to types * fixes: * update variable * fix for docs-landing * nonempty * update urlaliases * fixing urlaliases * spelling * Update extensions/redirects-and-publish/src/mutRedirectsAndPublish.ts Co-authored-by: rayangler <[email protected]> * Update extensions/redirects-and-publish/src/mutRedirectsAndPublish.ts Co-authored-by: rayangler <[email protected]> * raymund comments * clean up --------- Co-authored-by: rayangler <[email protected]>
✅ Deploy Preview for git-changed-file-extension canceled.
|
✅ Deploy Preview for populate-data-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for slack-deploy-extension canceled.
|
❌ Deploy Preview for redirects-and-publish-extension failed. Why did it fail? →
|
✅ Deploy Preview for snooty-cache-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for search-manifest-extension failed. Why did it fail? →
|
❌ Deploy Preview for site-links-display failed. Why did it fail? →
|
✅ Deploy Preview for persistence-module-ext canceled.
|
branberry
requested changes
Jan 6, 2025
| ): { snootyDb: SnootyDBName; searchDb: SearchDBName; poolDb: PoolDBName } => { | ||
| switch (env) { | ||
| case 'dotcomstg': | ||
| case dbEnvVars.DOTCOMSTG: |
There was a problem hiding this comment.
Hey Bianca, I'm not sure if using dbEnvVars here is what we want to do. This is getting the value of the that property, which we can set to be whatever. I think it makes sense to do it the way you had it previously, as switch statements typically just use concrete values instead of variable values.
There was a problem hiding this comment.
Hey Brandon, thanks for the review! That works for me to go back, but then I am just a little confused as to why we created the environment variables in netlify, are they to be used somewhere else in the repo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
DOP-5199
Notes
DEV, STD, PRD, DOTCOMSTG, DOTCOMPRD