fix feedback

src/Form/Type/UiElement/ButtonLinkType.php

@@ -70,8 +70,8 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
             ])
             ->add('target', ChoiceType::class, [
                 'choices'  => [
-                    'Open in the same frame as it was clicked (this is default)' => '_self',
-                    'Open in a new window or tab' => '_blank',
+                    'monsieurbiz_richeditor_plugin.ui_element.monsieurbiz.button.field.target_option.self' => '_self',
+                    'monsieurbiz_richeditor_plugin.ui_element.monsieurbiz.button.field.target_option.blank' => '_blank',
                 ],
             ])
             ->add('align', AlignmentType::class)

src/Resources/translations/messages.en.yml

@@ -81,6 +81,9 @@ monsieurbiz_richeditor_plugin:
         label: 'Label'
         link: 'Link'
         target: 'Target'
+        target_option:
+          self: 'Open in the same frame as it was clicked (this is default)'
+          blank: 'Open in a new window or tab'
     monsieurbiz.youtube:
       title: 'Youtube Element'
       short_description: 'A Youtube element.'

src/Resources/views/Admin/UiElement/button.html.twig

@@ -9,6 +9,8 @@
 #}
 {% set align = element.align is defined and element.align is not empty ? element.align : 'center' %}
 {% set target = element.target is defined and element.target is not empty ? element.target : '_self' %}
+{% set rel = element.target is defined and element.target == '_blank' ? 'rel="noopener noreferrer"' : '' }
+
 <p style="text-align: {{align}};">
-    <a href="{{ element.link }}" target="{{ element.target }}" rel="noopener noreferrer" class="ui primary button massive">{{ element.label }}</a>
+    <a href="{{ element.link }}" target="{{ element.target }}" {{ rel }} class="ui primary button massive">{{ element.label }}</a>
 </p>