Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test #41

Merged
merged 4 commits into from
Sep 7, 2023
Merged

test: add test #41

merged 4 commits into from
Sep 7, 2023

Conversation

yuta-hidaka
Copy link
Collaborator

@yuta-hidaka yuta-hidaka commented Sep 4, 2023 •
edited
Loading

Describe your changes

Added tests for utils lib.
#32

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

jinmayamashita
jinmayamashita approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@jinmayamashita jinmayamashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuta-hidaka yuta-hidaka merged commit 73a4025 into main Sep 7, 2023
@yuta-hidaka yuta-hidaka deleted the test/add-unit-test branch September 7, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinmayamashita jinmayamashita jinmayamashita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuta-hidaka @jinmayamashita