This repository has been archived by the owner on Sep 24, 2020. It is now read-only.
NOBUG tool_dataprivacy: Clear upgrade.php to be consistent with stables #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Jun, Shouldn't the 3rd param in https://github.com/moodlehq/moodle-tool_dataprivacy/pull/20/files#diff-c74097fbb0a2db56a0a98aaf7d6a2654R36 be 'tool'? |
When we initially released in the Moodle plugins site, we had a clean slate of the upgrade.php in stables. Do the same for master to keep them in sync.
|
Hi David, Aha, thanks, good catch! I have amended the commit. Edit: Crap, then the 34 and 33 branches also now have 'error' as the component. :s |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we initially released in the Moodle plugins site, we had a clean
slate of the upgrade.php in stables. Do the same for master to keep
them in sync.