Remove unnecessary code from import_from_xml

moodleou · Oct 27, 2023 · 72bf981 · 72bf981
1 parent 94b7785
commit 72bf981
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/questiontype.php b/questiontype.php
@@ -338,15 +338,13 @@ public function import_from_xml($data, $question, qformat_xml $format, $extra =
         $columns = $format->getpath($data, ['#', 'columns', 0, '#', 'column'], false);
         if ($columns) {
             $this->import_columns($format, $question, $columns);
-        } else {
-            $question->columns = [];
         }
+
         $rows = $format->getpath($data, ['#', 'rows', 0, '#', 'row'], false);
         if ($rows) {
             $this->import_rows($format, $question, $rows);
-        } else {
-            $question->rows = [];
         }
+
         $format->import_combined_feedback($question, $data, true);
         $format->import_hints($question, $data, true, true,
                 $format->get_format($question->questiontextformat));