Matrix: Reimplement get_possible_responses() for stats #746912 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkassaei
force-pushed
the
oum746912
branch
2 times, most recently
from
1d43ba3 to
df86da8
Compare
mkassaei
force-pushed
the
oum746912
branch
7 times, most recently
from
42bac5c to
ab1631e
Compare
mkassaei
force-pushed
the
oum746912
branch
2 times, most recently
from
b0536d5 to
f8ab39c
Compare
|
The proposed implementation would not acutally work. I have re-done it as one of the commits in branch main...wip746912-tim - along with other clean-up. (Note, the Backup Behat test is failing there. I will look at that tomorrow.) But, perhaps you could give it a revivew, please, @mkassaei |
|
Github actions now fully passing. |
|
Fixes merge manually. Thanks for the review Mahmoud. Closing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now ready for review.