Matrix: incomplete answer list not marked as expected. #826739

[BruceGoodGuy]

Hi, @AnupamaSarjoshi,
cc @timhunt,

I have finished development for this ticket. To reduce code duplication, I created a protected method validate_response_fields, which handles the verification logic for is_complete_response and is_gradable_response. Could you please review it?
Thanks.

[timhunt]

validate_response_fields may avoid duplicating one simple for loop. But, at the cost of making the code much harder to understand. Is that really a good trade-off?

For comparison, look at qtype match. Isn't this much easier to understand? https://github.com/moodle/moodle/blob/main/question/type/match/question.php#L308 (Note, there, in is_complete_response, I would not use the $complete variable. That could be written more like is_gradable_response.)

[AnupamaSarjoshi]

Thanks @BruceGoodGuy for working on this issue. The changes look good and have been merged :)