Define class fields in question class to stop phpi 8.2 deprecation #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for trying to help, but we already have our own fix for this in OU code. I need to push that to GitHub. |
|
No worries. I did not know the question type existed until I saw this in the Moodle org forums. |
|
It seems this problem has not been fixed. Error is still shown when using PHP 8.2 and Moodle 4.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.2 was throwing Deprecated: Creation of dynamic property qtype_recordrtc_question::$timelimitinseconds is deprecated
and
Deprecated: Creation of dynamic property qtype_recordrtc_question::$mediatype is deprecated
Messages when debug is set to developer.
I have created two new fields in the question class
Note: the ci errors do not seem to have been introduced by this code. There are at least 7 items that will be fixed with phpcbf.