Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UBE, GNT, PACT configurators on Alfajores #30

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Add UBE, GNT, PACT configurators on Alfajores #30

wants to merge 14 commits into from

Conversation

x-moola
Copy link
Contributor

@x-moola x-moola commented Jun 17, 2022 •
edited
Loading

Description

  • Add configurator files on Alfajores for token GNT, UBE and PACT
  • Update cli to recognize the new tokens on Alfajores
  • Mainnet params haven't been decided yet, I'll create a separate PR for the configurator contracts on mainnet once those are confirmed.

@x-moola x-moola changed the title Add UBE and GNT configurators Add UBE, GNT, PACT configurators on Alfajores Jun 20, 2022
lastperson
lastperson approved these changes Jul 16, 2022
View reviewed changes
Copy link
Collaborator

@lastperson lastperson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a step to the run book where the multisig sends a transaction to the LendingRateOracle.setMarketBorrowRate(asset, rate);
This should be done before the configuration, because it doesn't affect old assets.
Previously this step was performed by the EmergencyAdmin, now the rate oracle ownership is transferred to the big Multisig: https://explorer.celo.org/tx/0x9bc7fb332f1142c592a915fc1b7d7b354cf0dbd361031c8a2f1613d77411e372/internal-transactions

Alfajores: 0x300062ea5B3E26Ff00D7b0628ee11564700Ef61d
Mainnet: 0xaA6e0F0B63287EAC5DDBEefd1f133Fc7F554ee9b

Rate 30000000000000000000000000 (0.03 RAY, e27) is 3% base rate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastperson lastperson lastperson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@x-moola @lastperson