Merge pull request #1125 from rsrdesarrollo/master

add disable TLD check option
mooltipass · Jan 27, 2023 · c55121c · c55121c
2 parents ed65010 + ff93200
commit c55121c
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 4 deletions.
diff --git a/src/CredentialsManagement.cpp b/src/CredentialsManagement.cpp
@@ -1415,7 +1415,7 @@ void CredentialsManagement::checkLinkingOnLoginSelected(const QModelIndex &srcIn
     }
 }
 
-QString CredentialsManagement::processMultipleDomainsInput(const QString& service, const QString &domains)
+QString CredentialsManagement::processMultipleDomainsInput(const QString& service, const QString &domains, const bool disable_tld_check)
 {
 #if QT_VERSION < QT_VERSION_CHECK(5, 15, 0)
     auto splitBehavior = QString::SkipEmptyParts;
@@ -1439,7 +1439,7 @@ QString CredentialsManagement::processMultipleDomainsInput(const QString& servic
             domain.prepend('.');
         }
         ParseDomain dom(serviceDomain + domain);
-        if (domain == dom.tld())
+        if (disable_tld_check || domain == dom.tld())
         {
             validDomains.append(domain);
         }
@@ -1687,13 +1687,15 @@ void CredentialsManagement::onTreeViewContextMenuRequested(const QPoint& pos)
                                 serviceNameChanged = true;
                             }
                         }
+                        QSettings s;
                         bool ok = false;
+                        bool disable_tld_check = s.value("settings/disable_tld_check", false).toBool();
                         QString text = QInputDialog::getText(this, tr("Multiple Domains for %1").arg(pServiceItem->name()),
                                                                  tr("Enter comma separated domain extensions:"), QLineEdit::Normal,
                                                                  defaultDomains, &ok);
                         if (ok)
                         {
-                            text = processMultipleDomainsInput(serviceName, text);
+                            text = processMultipleDomainsInput(serviceName, text, disable_tld_check);
                             if (!text.isEmpty())
                             {
                                 pServiceItem->setMultipleDomains(text);

diff --git a/src/CredentialsManagement.h b/src/CredentialsManagement.h
@@ -142,7 +142,7 @@ private slots:
 
     void checkLinkingOnLoginSelected(const QModelIndex &srcIndex);
 
-    QString processMultipleDomainsInput(const QString& service, const QString &domains);
+    QString processMultipleDomainsInput(const QString& service, const QString &domains, const bool disable_tld_check);
 
     bool isUICategoryClean() const;
 

diff --git a/src/MainWindow.cpp b/src/MainWindow.cpp
@@ -664,6 +664,7 @@ MainWindow::MainWindow(WSClient *client, DbMasterController *mc, QWidget *parent
 
     //Check is ssh agent opt has to be checked
     ui->checkBoxSSHAgent->setChecked(s.value("settings/auto_start_ssh").toBool());
+    ui->checkBoxTLDCheck->setChecked(s.value("settings/disable_tld_check").toBool());
     ui->lineEditSshArgs->setText(s.value("settings/ssh_args").toString());
 
     ui->scrollArea->setStyleSheet("QScrollArea { background-color:transparent; }");
@@ -1463,6 +1464,12 @@ void MainWindow::on_checkBoxSSHAgent_stateChanged(int)
     s.setValue("settings/auto_start_ssh", ui->checkBoxSSHAgent->isChecked());
 }
 
+void MainWindow::on_checkBoxTLDCheck_stateChanged(int)
+{
+    QSettings s;
+    s.setValue("settings/disable_tld_check", ui->checkBoxTLDCheck->isChecked()); 
+}
+
 void MainWindow::on_pushButtonExportFile_clicked()
 {
     wsClient->exportDbFile(Common::SIMPLE_CRYPT);

diff --git a/src/MainWindow.h b/src/MainWindow.h
@@ -128,6 +128,7 @@ private slots:
     void on_pushButtonAutoStart_clicked();
 
     void on_checkBoxSSHAgent_stateChanged(int arg1);
+    void on_checkBoxTLDCheck_stateChanged(int arg1);
 
     void on_pushButtonExportFile_clicked();
     void on_pushButtonImportFile_clicked();

diff --git a/src/MainWindow.ui b/src/MainWindow.ui
@@ -4065,6 +4065,37 @@ Hint: keep your mouse positioned over an option to get more details.</string>
                 </item>
                </layout>
               </item>
+              <item>
+               <layout class="QHBoxLayout" name="horizontalLayout_15">
+                <item>
+                 <widget class="QLabel" name="label_27">
+                  <property name="text">
+                   <string>Allow to use invalid or private TLDs</string>
+                  </property>
+                 </widget>
+                </item>
+                <item>
+                 <spacer name="horizontalSpacer_63">
+                  <property name="orientation">
+                   <enum>Qt::Horizontal</enum>
+                  </property>
+                  <property name="sizeHint" stdset="0">
+                   <size>
+                    <width>40</width>
+                    <height>20</height>
+                   </size>
+                  </property>
+                 </spacer>
+                </item>
+                <item>
+                 <widget class="QCheckBox" name="checkBoxTLDCheck">
+                  <property name="text">
+                   <string>Disable TLD check</string>
+                  </property>
+                 </widget>
+                </item>
+               </layout>
+              </item>
               <item>
                <layout class="QHBoxLayout" name="horizontalLayout_19">
                 <item>