Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix check-wasm-size #3156

Closed
wants to merge 12 commits into from
Closed

chore(ci): fix check-wasm-size #3156

wants to merge 12 commits into from

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Jan 24, 2025

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@RomarQ RomarQ added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Jan 24, 2025
@RomarQ RomarQ self-assigned this Jan 24, 2025
Copy link
Contributor

github-actions bot commented Jan 24, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2272 KB (no changes) ✅

Moonbeam runtime: 2252 KB (no changes) ✅

Moonriver runtime: 2244 KB (no changes) ✅

Compared to latest release (runtime-3401)

Moonbase runtime: 2272 KB (+240 KB compared to latest release) ⚠️

Moonbeam runtime: 2252 KB (+240 KB compared to latest release) ⚠️

Moonriver runtime: 2244 KB (+232 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Coverage Report

@@                    Coverage Diff                    @@
##           master   rq/fix-wasm-size-check     +/-   ##
=========================================================
  Coverage   74.58%                   74.58%   0.00%     
  Files         377                      377             
  Lines       96042                    96042             
=========================================================
  Hits        71632                    71632             
  Misses      24410                    24410             
Files Changed Coverage

Coverage generated Fri Jan 24 21:30:04 UTC 2025

RomarQ and others added 7 commits January 24, 2025 19:15
This reverts commit bd49d25.
refactor: ♻️ update deprecated options in both invocations of the command within the script

feat: ✨ add default preset for RuntimeGenesisConfig

Revert "feat: ✨ add default preset for RuntimeGenesisConfig"

This reverts commit 52436cb.

feat: ✨ add genesis builder dummy development preset

refactor: ♻️ implement GenesisBuilder within each runtime

refactor: ♻️ move moonbase runtime test config to runtime

refactor: 🎨 improve structure

refactor: ♻️ move moonbeam runtime test config to runtime

refactor: ♻️ move moonriver runtime test config to runtime

fix: 🔥 remove unused dep

chore: 📄 add copyright

refactor: 🔥 complete move of testnet_genesis functions to runtime

refactor: ⚰️ remove dead functions *_inflation_config

refactor: ♻️ add get_preset and preset_names functions

build: ✨

refactor: ♻️ correctly use with_genesis_config_preset_name in client code

refactor: ♻️ use with_genesis_config_preset_name in test_spec

refactor: 🔥 remove serde_json feature

fix json serialization of GenesisConfig in xcm-transactor

fix serde_json dependendency in no_std environemnt

simplify code
This reverts commit 5f60c3c.
@RomarQ
Copy link
Contributor Author

RomarQ commented Jan 24, 2025

Cherry-picked the changes to #3138, closing.

@RomarQ RomarQ closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants