Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notarize runtime upgrade differences: runtime-3500 #3179

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 5, 2025

Automated changes by create-pull-request GitHub action

@github-actions github-actions bot added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Feb 5, 2025
@github-actions github-actions bot requested review from RomarQ and stiiifff February 5, 2025 10:25
@RomarQ RomarQ marked this pull request as ready for review February 5, 2025 12:20
RomarQ
RomarQ previously approved these changes Feb 5, 2025
stiiifff
stiiifff previously approved these changes Feb 5, 2025
@github-actions github-actions bot dismissed stale reviews from stiiifff and RomarQ via 74ad7f4 February 5, 2025 12:54
@github-actions github-actions bot requested review from RomarQ and stiiifff February 5, 2025 12:54
@RomarQ RomarQ force-pushed the runtime-diff-3500 branch from be900a4 to 009e33e Compare February 5, 2025 13:07
Copy link
Contributor Author

github-actions bot commented Feb 5, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2416 KB (no changes) 🚨

Moonbeam runtime: 2408 KB (no changes) 🚨

Moonriver runtime: 2384 KB (no changes) ✅

Compared to latest release (runtime-3401)

Moonbase runtime: 2416 KB (+384 KB compared to latest release) 🚨

Moonbeam runtime: 2408 KB (+396 KB compared to latest release) 🚨

Moonriver runtime: 2384 KB (+372 KB compared to latest release) ⚠️

Copy link
Contributor Author

github-actions bot commented Feb 5, 2025

Coverage Report

@@                 Coverage Diff                  @@
##           master   runtime-diff-3500     +/-   ##
====================================================
  Coverage   74.61%              74.61%   0.00%     
  Files         380                 380             
  Lines       95983               95983             
====================================================
  Hits        71611               71611             
  Misses      24372               24372             
Files Changed Coverage

Coverage generated Wed Feb 5 13:43:29 UTC 2025

@RomarQ RomarQ merged commit 00bc7bf into master Feb 5, 2025
57 of 60 checks passed
@RomarQ RomarQ deleted the runtime-diff-3500 branch February 5, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants