Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI 🚚: Fix Weight Diff report #3180

Merged
merged 3 commits into from
Feb 7, 2025
Merged

CI 🚚: Fix Weight Diff report #3180

merged 3 commits into from
Feb 7, 2025

Conversation

pLabarta
Copy link
Contributor

@pLabarta pLabarta commented Feb 5, 2025

What does it do?

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Moonbase Weight Difference Report

File Extrinsic Old New Change Percent
runtime/moonbase/src/weights/pallet_assets.rs force_create 160.72us 150.00us -6.67%

@pLabarta pLabarta added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) ci Continuous Integration pipeline labels Feb 5, 2025
@pLabarta pLabarta marked this pull request as ready for review February 5, 2025 13:37
@pLabarta pLabarta requested review from a team as code owners February 5, 2025 13:37
Copy link
Contributor

github-actions bot commented Feb 5, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2416 KB (no changes) 🚨

Moonbeam runtime: 2408 KB (no changes) 🚨

Moonriver runtime: 2384 KB (no changes) ✅

Compared to latest release (runtime-3401)

Moonbase runtime: 2416 KB (+384 KB compared to latest release) 🚨

Moonbeam runtime: 2408 KB (+396 KB compared to latest release) 🚨

Moonriver runtime: 2384 KB (+372 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Coverage Report

@@                      Coverage Diff                      @@
##           master   pablo/ci/fix-weight-report     +/-   ##
=============================================================
  Coverage   74.61%                       74.61%   0.00%     
  Files         380                          380             
  Lines       95983                        95983             
=============================================================
  Hits        71611                        71611             
  Misses      24372                        24372             
Files Changed Coverage

Coverage generated Wed Feb 5 14:14:50 UTC 2025

@RomarQ RomarQ added the A8-mergeoncegreen Pull request is reviewed well. label Feb 6, 2025
@RomarQ RomarQ merged commit b85ac45 into master Feb 7, 2025
45 of 49 checks passed
@RomarQ RomarQ deleted the pablo/ci/fix-weight-report branch February 7, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8-mergeoncegreen Pull request is reviewed well. B0-silent Changes should not be mentioned in any release notes ci Continuous Integration pipeline D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants