Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update check-mkdocs-build.yml #221

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Update check-mkdocs-build.yml #221

merged 1 commit into from
Jan 3, 2025

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Jan 3, 2025

Description

This should fix the failing builds. We removed the strings around variables in the mkdocs.yml file, so this needs to be updated too

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this page requires a disclaimer, I have added one
  • If pages have been moved around, I have created an additional PR in tanssi-mkdocs to update redirects

@eshaben eshaben added the A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.) label Jan 3, 2025
augustocollado
augustocollado approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@augustocollado augustocollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshaben eshaben merged commit c05163a into main Jan 3, 2025
1 check failed
@eshaben eshaben deleted the eshaben/workflow-fix branch January 3, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustocollado augustocollado augustocollado approved these changes

@albertov19 albertov19 Awaiting requested review from albertov19

@dawnkelly09 dawnkelly09 Awaiting requested review from dawnkelly09

Assignees
No one assigned
Labels
A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshaben @augustocollado