Adding third party module - example #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustocollado
added
the
A2 - Maintenance Minor
albertov19
requested changes
Jan 10, 2024
Co-authored-by: albertov19 <[email protected]>
albertov19
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Looks great! As my last piece of feedback, I would use now termynal
It will be an easy thing to adapt here. Check the reference PR -> #74
eshaben
reviewed
Jan 16, 2024
…lado/third-party-error-example
Co-authored-by: Erin Shaben <[email protected]>
|
@augustocollado you can remove the terminal image then :) |
|
@augustocollado don't forget the |
Ouch! I deleted the image, but I don't know how that copy with that name got in that new folder I created. Fixed.
Sorry about that, I thought I had gotten them all :S |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the third-party module article by illustrating the process of adding a third-party pallet, the error you'll get when trying to compile, and how to apply the solution by patching the deps with dinner.
This section relies on this other repo containing the pallet: https://github.com/papermoonio/pallet-toggle
Checklist
moonbeam-mkdocsto update redirects