Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize the structure of the snippets and images #75

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Jan 12, 2024

Description

This PR organizes the snippets and images to match the structure of the docs.

Checklist

  • I have added a label to this PR 🏷️

@eshaben eshaben added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Jan 12, 2024
Copy link
Collaborator

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eshaben is there a way to check if this compiles correctly without checking file by file? The normal compiler does not show an error if the snippet does not exist.

@eshaben
Copy link
Contributor Author

eshaben commented Jan 12, 2024

@eshaben is there a way to check if this compiles correctly without checking file by file? The normal compiler does not show an error if the snippet does not exist.

No, I don't think there is. I did check file-by-file before submitting the PR though, and all of the snippets render as they should.

@albertov19 albertov19 self-requested a review January 15, 2024 09:41
Copy link
Collaborator

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Did not check things 1 by 1, just a few random ones

Copy link
Contributor

@augustocollado augustocollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@eshaben eshaben merged commit 46159c7 into main Jan 16, 2024
1 check passed
@eshaben eshaben deleted the eshaben/organize branch January 16, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants