Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed middleware not approving for token transfer #29

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

NindoK
Copy link
Contributor

@NindoK NindoK commented Jan 29, 2025

Fix for bug in middleware which doesn't approve ODefaultOperatorsRewards contract for the safeTransfer.

Copy link

> Coverage generated

Coverage after merging fix/add-approve-on-middleware into main will be
52.69%▴ +0.55%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
script
   DeployCollateral.s.sol20%100%33.33%17.65%24–25, 36, 39–41, 43–44, 46, 48–51, 53
   DeploySymbiotic.s.sol61.46%100%50%61.63%147, 150, 153–158, 160, 327–330, 333–336, 338, 349–352, 354–358, 360, 362–366
   DeployTanssiEcosystem.s.sol0%0%0%0%105, 110–115, 117–119, 121–123, 126–127, 129–131, 133, 139, 143–144, 157, 157–158, 162, 162–163, 165–169, 172, 172–173, 175, 177–181, 183, 183–185, 185–186, 188, 190–194, 197, 197–198, 200, 203–204, 204–206, 208–209, 214–215, 220–221, 221–223, 225, 228–229, 239, 241–242, 242–244, 248, 250–254, 256, 256, 256, 258, 260, 262–264, 273–274, 276–293, 296, 299–301, 303–306, 309–316
   DeployVault.s.sol60%45.45%50%64.58%113, 113–114, 117, 117–118, 122, 150, 162, 174, 174–175, 216, 228, 230, 242, 244–246, 248, 88, 94–95
   HelperConfig.s.sol0%0%0%0%37–38, 38, 38–39, 41, 45–48, 51–52, 55–71, 73, 86–87, 89, 91
script/test
   Demo.s.sol0%100%0%0%100–101, 103–105, 107–108, 110, 113–114, 125–130, 132–133, 135–139, 141–143, 145–150, 153, 156–158, 161, 169–172, 174–178, 180–181, 183–189, 191, 194, 197, 200–203, 206, 209, 212, 221, 224, 226–229, 231–233, 235–239, 241–243, 245–251, 253–255, 257–259, 261–264, 266–268, 270–271, 273–275, 277–281, 284–288, 292, 87–93, 95–97, 99
   DeployTanssiEcosystemDemo.s.sol0%0%0%0%110–111, 111–112, 115–120, 122–124, 126–132, 134–135, 137–139, 141–142, 144, 144–145, 147, 151–152, 165, 165–166, 170, 170–171, 173–177, 180, 180–181, 183, 185–189, 191, 191–193, 193–194, 196, 198–202, 205, 205–206, 208, 211–212, 212–214, 216–217, 222–223, 228–234, 237–239, 242–243, 253, 255–256, 256–258, 262, 264–268, 270, 270, 270, 272, 274, 276, 278–281, 283–289, 291–296, 298–303, 305–306, 315, 318, 321, 324–327, 329–350, 353, 356–358, 360–363, 366–373
src/contracts/libraries
   MapWithTimeData.sol100%100%100%100%
   SimpleKeyRegistry32.sol100%100%100%100%
src/contracts/middleware
   Middleware.sol100%100%100%100%
src/contracts/rewarder
   ODefaultOperatorRewards.sol100%100%100%100%
   ODefaultStakerRewards.sol100%100%100%100%
test/mocks
   FeeToken.sol100%100%100%100%
   MapWithTimeDataContract.sol100%100%100%100%
   Token.sol100%100%100%100%
test/mocks/symbiotic
   DelegatorMock.sol100%100%100%100%
   RegistryMock.sol100%100%100%100%

@NindoK NindoK merged commit 1b7741e into main Jan 30, 2025
5 checks passed
@NindoK NindoK deleted the fix/add-approve-on-middleware branch January 30, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants