Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stream http request instead of consuming all #174

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

adamdecaf
Copy link
Member

Issue: #172

@adamdecaf
Copy link
Member Author

@mfdeveloper508 Can you help figure out why some tests are failing?

----------------------------------------------------------------------
FAIL: suite_test.go:249: ServerTest.TestConvertWithValidJsonRequest

suite_test.go:262:
    err := writer.WriteField("format", "json")
... obtained int = 400
... expected int = 200

E1: EOF

 EOF
 

----------------------------------------------------------------------
FAIL: suite_test.go:136: ServerTest.TestJsonRequestPrint

suite_test.go:149:
    ...
... obtained int = 400
... expected int = 200

E1: invalid json file
E2: invalid format: unknown
E1: has an invalid segment (header)
OOPS: 14 passed, 2 FAILED
--- FAIL: Test (0.02s)
FAIL
FAIL	github.com/moov-io/metro2/pkg/server	48.470s
FAIL

@codecov-commenter
Copy link

Codecov Report

Merging #174 (dced7ce) into master (19dff26) will decrease coverage by 0.02%.
Report is 4 commits behind head on master.
The diff coverage is 79.16%.

❗ Current head dced7ce differs from pull request most recent head 517d499. Consider uploading reports for the commit 517d499 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   79.31%   79.29%   -0.02%     
==========================================
  Files          16       16              
  Lines        2258     2280      +22     
==========================================
+ Hits         1791     1808      +17     
- Misses        283      287       +4     
- Partials      184      185       +1     

@adamdecaf adamdecaf merged commit 7742411 into moov-io:master Dec 21, 2023
6 checks passed
@adamdecaf adamdecaf deleted the issue-172 branch December 21, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants