Added OkHttpClient API call for auth check #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harveymmaunders
changed the title
willosborne
reviewed
Jan 3, 2025
| builder.header("Authorization", "Bearer " + msClientAuthTokenService.getAccessToken()); | ||
| String token = msClientAuthTokenService.getAccessToken(); | ||
| logger.debug("Retrieved token"); | ||
| DecodedJWT jwt = JWT.decode(token); |
There was a problem hiding this comment.
is this JWT actually used anywhere or logged? might be worth highlighting that this is optional (and the dependency that is needed for this)
willosborne
reviewed
Jan 3, 2025
| @@ -38,6 +55,8 @@ public class MsRetrofitWrapper { | |||
| */ | |||
| public MsRetrofitWrapper(String url, Level logLevel) throws Exception { | |||
| this.msClientAuthTokenService = new MsClientAuthTokenService(MICROPROFILE_CONFIG_SERVICE); | |||
| this.url = url; | |||
| this.logLevel = logLevel; | |||
There was a problem hiding this comment.
Is this needed on the constructor? is there any way people can omit having to set this explicitly and instead do via microprofile config? (e.g. in Spring, you would rarely never set a log level directly in code)
There was a problem hiding this comment.
Also, is this like a debug/info/warn style level or is it more detailed/specific?
willosborne
reviewed
Jan 3, 2025
| @@ -94,4 +115,16 @@ public Retrofit getRetrofit() { | |||
| public <T> T createService(Class<T> serviceInterface) { | |||
| return this.getRetrofit().create(serviceInterface); | |||
| } | |||
|
|
|||
| public void checkAuthorisation(String apiEndpoint) throws IOException { | |||
There was a problem hiding this comment.
Javadoc on this method to explain what it's for
harveymmaunders
added a commit
that referenced
this pull request
Jan 17, 2025
…samples/python/rest/black-24.10.0 pip-rest: bump black from 24.3.0 to 24.10.0 in /client-samples/python/rest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added API call to help check authorisation. Don't need to configure retrofit service as just uses an OkHttpClient to call the API and print response code and body.
Added logging debugs for JWTs. They are also decoded using JWT library if more information is needed.
In the tests, changed the MOCK_TOKEN to a fake JWT that can be decoded.