TESTPLAN-2538: minor fixes for auto-parts #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyifan
force-pushed
the
bugfix
branch
2 times, most recently
from
1b05aef to
41d8c21
Compare
Pyifan
force-pushed
the
bugfix
branch
4 times, most recently
from
be24d0b to
6431f6a
Compare
Pyifan
commented
Oct 24, 2023
| def context_input(self) -> Dict[str, Any]: | ||
| """All attr of self in a dict for context resolution""" | ||
| return {attr: getattr(self, attr) for attr in dir(self)} | ||
|
|
There was a problem hiding this comment.
move to Entity so that both Driver and Test can use this
Pyifan
force-pushed
the
bugfix
branch
2 times, most recently
from
a6ba525 to
89cb825
Compare
Pyifan
commented
Oct 25, 2023
| @@ -65,23 +64,6 @@ def test_expand(driver_context): | |||
| assert expand(cv, driver_context, int) == 123 | |||
|
|
|||
|
|
|||
| def test_expand_env(driver_context): | |||
There was a problem hiding this comment.
this test is moved to internal
…rough jinja/tempita rendering
yuxuan-ms
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
Clearly and concisely describe the problem.
Solution description
Describe your code changes in detail for reviewers.
Checklist: