Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the plan wait properly for interactive start #1019

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

kn-ms
Copy link
Contributor

@kn-ms kn-ms commented Nov 10, 2023

moved the helper to a place from where it can be used in the executable as well as in the testcases.

Bug / Requirement Description

In one of the testcase we do not wait for the the proper
interactive startup which cause raceconditions

Solution description

Describe your code changes in detail for reviewers.

use the same helper as elsewhere,
moved the helper to it's own module so
it can be used in test as well in the executable

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

moved the helper to a place from where it can be used in
the executable as well as in the testcases.
@kn-ms kn-ms requested a review from Pyifan as a code owner November 10, 2023 14:06
@kn-ms kn-ms merged commit b679529 into morganstanley:main Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants