Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/save exception raised by resource hooks to step_results #1169

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Fix/save exception raised by resource hooks to step_results #1169

merged 5 commits into from
Jan 10, 2025

Conversation

zhenyu-ms
Copy link
Contributor

Bug / Requirement Description

step_results wasn't correctly set in a previous refactor, resulting in unexpected steps being executed

Solution description

see code

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@zhenyu-ms zhenyu-ms requested a review from a team as a code owner January 7, 2025 06:20
@zhenyu-ms zhenyu-ms force-pushed the resource-hook-steps branch from def14ec to aed2e7a Compare January 10, 2025 03:14
@zhenyu-ms zhenyu-ms merged commit b63fb7c into morganstanley:main Jan 10, 2025
15 checks passed
@zhenyu-ms zhenyu-ms deleted the resource-hook-steps branch January 10, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pyifan Pyifan Pyifan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenyu-ms @Pyifan