-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Style] 친구 모달 및 모달 내 컴포넌트 구현 #217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issues
✅ 작업 리스트
🔧 작업 내용
1. FriendsModalContents
친구 모달 최상위 컴포넌트로,
위의 세가지 경우가 삼항연산자로 조건부 렌더링됩니다.
2. TabSelect
친구 목록 탭 내 컴포넌트
1. FriendInfo
formatSecondsForFriendsList(friend?.time)
2. ButtonAddFriend
친구 요청 탭 내 컴포넌트
1. InputSendRequest
2. FriendsListRequested
3. ButtonRequestAction
🤔 궁금한 점
친구 요청 탭에서
위 경우의 gui가 없어서 담당 디자인 파트에 요청해놓은 상태입니다..!
📸 스크린샷 / GIF / Link
친구 목록 empty일때
친구 목록 탭
2024-11-04.3.28.41.mov
친구 요청 탭
2024-11-04.3.30.23.mov
친구 요청 보내기 input 유효성 검사
2024-11-04.3.33.46.mov
영상에서는 input창의 border색이 적용 안되는 것처럼 보이는데, border 잘 적용된 거 확인했습니다..! 화면 캡처하거나 로컬에서 직접 돌려보면 적용한대로 잘 보이는데 화면녹화 영상에서만 하면 저렇게 보이네요.. 실제 스타일이 적용되지 않는 문제가 아니라 화면 녹화 비디오의 호환성 문제여서 신경 안쓰셔도 될 것 같습니다!
밑에는 실제로 보이는 화면
