Add slippage protection to reallocate

[Rubilmax]

No description provided.

[Jean-Grimal]

Is it really useful to protect against such attacks ? I mean what would be the incentive for an attacker to prevent vaults allocators to disable a market ?

[Rubilmax]

I think you are referring to:

metamorpho/src/MetaMorpho.sol

Lines 359 to 362 in 04ef549

	// Guarantees that unknown frontrunning donations can be withdrawn, in order to disable a market.
	if (allocation.shares == type(uint256).max) {
	allocation.shares = MORPHO.supplyShares(allocation.marketParams.id(), address(this));
	}

Though I think it's off the topic of the issue, which is about limiting the impact of slippage on reallocate calls made from an EOA or an unprotected contract: if we allow to pass in shares to supply to Morpho or withdraw from Morpho, there can be unexpected slippage
So this issue is not about an attack that prevents disabling a market

Still we can discuss about it: let's refer to your issue as issue 1 and mine as issue 2

I think the comment for issue 1 must be updated because it's not only about frontruns anymore: if you want to ensure you withdraw all from a market, you need to make sure you redeem all shares (otherwise interest may accrue over the input assets)