fix(reallocate): prevent slippage #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
MathisGD and
Jean-Grimal
Rubilmax
force-pushed
the
fix/prevent-slippage
branch
from
c0fd883 to
07e00ba
Compare
MerlinEgalite
approved these changes
Nov 2, 2023
Rubilmax
commented
Nov 3, 2023
Jean-Grimal
approved these changes
Nov 3, 2023
|
replaced by #307 |
It is based on it! The 2 PRs don't address the same issue |
|
ah you're right, can you update it then? |
…o fix/prevent-slippage
QGarchery
reviewed
Nov 14, 2023
Comment on lines
-34
to
-35
| /// @notice The amount of shares to allocate. | ||
| uint256 shares; |
There was a problem hiding this comment.
We should also change the dev comment above the struct @MerlinEgalite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reallocate#296This PR protects the allocator from bearing slippage by simply not allowing to withdraw/supply shares. The allocator can still withdraw all from a market by passing
type(uint256).max