should reject empty Consumer (#624)

Signed-off-by: spacewander <[email protected]>
mosn · Jul 4, 2024 · b52c8ae · b52c8ae
1 parent 56102be
commit b52c8ae
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/types/apis/v1/validation.go b/types/apis/v1/validation.go
@@ -287,6 +287,10 @@ func NormalizeK8sGatewayProtocol(protocol gwapiv1.ProtocolType) string {
 }
 
 func ValidateConsumer(c *Consumer) error {
+	if len(c.Spec.Auth) == 0 {
+		return errors.New("authn filter is required")
+	}
+
 	for name, filter := range c.Spec.Auth {
 		plugin := plugins.LoadPluginType(name)
 		if plugin == nil {

diff --git a/types/apis/v1/validation_test.go b/types/apis/v1/validation_test.go
@@ -739,6 +739,13 @@ func TestValidateConsumer(t *testing.T) {
 			},
 			err: "this http filter can not be added by the consumer: keyAuth",
 		},
+		{
+			name: "empty",
+			consumer: &Consumer{
+				Spec: ConsumerSpec{},
+			},
+			err: "authn filter is required",
+		},
 	}
 
 	for _, tt := range tests {