Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Add option to pass flags not used for host tools #689

Merged
merged 1 commit into from
Dec 24, 2024
Merged

cmake: Add option to pass flags not used for host tools #689

merged 1 commit into from
Dec 24, 2024

Conversation

jbruechert
Copy link
Contributor

This allows to target machines that support more instructions than the build machine.

Not sure if this is a good way to achieve this, but it at least doesn't require significant changes.

@felixguendling
Copy link
Member

Compiling mimalloc with -Weverything [...] -Werror has a good chance to cause trouble because we don't want to fix random warnings in mimalloc when we update. So maybe it would be better to have a separate set of flags (MOTIS_ARCH_FLAGS?) that's independent of the aggressive -Weverything [...] -Werror flags that are only relevant for our own code.

@jbruechert
Copy link
Contributor Author

That's pretty mich what this does except for different variable naming, isn't it?

@felixguendling
Copy link
Member

Ahh. Mistook it for motis-compile-options.

@felixguendling felixguendling merged commit cc02b4c into motis-project:master Dec 24, 2024
11 of 12 checks passed
D3vZro added a commit to MoViDe-Project/motis that referenced this pull request Jan 30, 2025
@D3vZro @MichaelKutzner
@pablohoch @felixguendling @jbruechert @traines-source @Altonss
chore: Bump MOTIS version to 2.0.14 (#37)
699cef3 
* Use `maxTravelTime` to filter results (motis-project#668)

* Use 'maxTravelTime' to filter results

* Change unit to minutes

* Fix formatting

* Fix type for MSVC build

* Update nigiri dependency

* Set limit for maximum travel time

* GBFS: Performance/Memory Improvements + Vehicle Types (motis-project#670)

* gbfs: partition providers, faster updates, less memory usage

* fix vehicle_docks_available

* slightly faster geofencing zone mapping

* rename provider_cache -> provider_file_infos

* ts formatting

* formatting

* clang fixes

* clang fix

* clang fixes

* trying to fix apple clang

* static_cast all the things

* review changes

* fix include

* 65k gbfs providers should be enough

* remove obsolete comment

* sort vehicle status before diff

* fill cache during gbfs update

* cleanup

* partition vehicle types by form factor + propulsion type

* rental api changes (RENTAL mode + form factor + propulsion type)

* ui fix

* rename provider segment -> products

* vehicle type id -> idx

* rename more segment -> products

* one more r-tree to speed up geofencing zone mapping

* clang fix

* fix api descriptions

* api: add rental provider filter

* ui: fix direct connection display for rental connections

* return constraint support, allow roundtrip for direct connections

* ui formatting

* fix missing gbfs data after update

* http proxy support

* share decompressed bitvecs between routing requests

* fix missing initializer

---------

Co-authored-by: Felix Gündling <[email protected]>

* replace wheelchair with pedestrianProfile and useRoutedTransfers params (motis-project#683)

* replace wheelchair with pedestrianProfile and useRoutedTransfers parameters

* fix test

* ui: debounce search requests

* increase trains limit to support big cities like Paris/London/..

* add timeout option

* cli changes (motis-project#685)

* cli changes

* wip

* update nigiri

* Update README.md: not beta anymore

* update nigiri: speedup ~8% by not finding 24h+ transfers

* basic benchmark and QA tooling (motis-project#686)

* bench

* wip

* wip

* wip

* wip

* fix command line flag handling

* full dataset test (motis-project#687)

* full dataset test

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* body size limit 128M

* cmake: Add option to pass flags not used for host tools (motis-project#689)

* update nigiri: rt update fixes time travel

* more rebostness against invalid delay update data

motis-project/nigiri#162

* update nigiri: trim stop time before empty check for interpolation

* motis config: fix crash with no parameters

* update nigiri: better trip names (motis-project#695)

* polish translation

* Detailed transfers flag + output exactly what nigiri routed (motis-project#698)

* wip

* output exactly what nigiri routed

* remove logging output

* remove unused variable

* fix eval

* wip

* wip

* Initial style guide docs/STYLE.md

* Fix missing closing tag (motis-project#700)

* Fix missing closing tag

* Add sections for important tools

This adds a section for `strong`, as well as `vector_map` and `vecvec`.

* Fix index out of range for stop_times last arrival of multi-section run (motis-project#704)

* fix index out of range for stop_times last arrival of multi-section run

* follow style guide

Co-authored-by: Felix Gündling <[email protected]>

---------

Co-authored-by: Felix Gündling <[email protected]>

* (Mobile) UI improvements (motis-project#705)

* ui: move components to lib

* ui: make components more responsive

* ui: more compact layout

* ui: i18n fixes

* ui: make toggle button state more visible

* ui: error handling, avoid repeated effect triggering

* ui: more small screen adjustments

* ui: url state handling

* ui: show backend error msgs, compact transfer display

* UI fixes (motis-project#710)

* ui: fall back to black routeTextColor (gtfs spec)

* update ui deps

* ui: workaround to avoid clickthrough

* ui: linting

* update nigiri: monotonicity enforcement on utc times (fixes interpolation for frequency expanded trips)

* ui changes

* Improve formatDuration (motis-project#713)

* Update formatDuration.ts

* fix formatting

* fix formatting

* Fix formatting

* osr_footpaths: add missing footpaths (motis-project#707)

* osr_footpaths: add missing footpaths

* update osr (ramp support)

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* formatting

---------

Co-authored-by: Michael Kutzner <[email protected]>
Co-authored-by: Pablo Hoch <[email protected]>
Co-authored-by: Felix Gündling <[email protected]>
Co-authored-by: Felix Gündling <[email protected]>
Co-authored-by: Jonah Brüchert <[email protected]>
Co-authored-by: Traines <[email protected]>
Co-authored-by: Altonss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbruechert @felixguendling