Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Mobile) UI improvements #705

Merged
merged 9 commits into from
Jan 19, 2025

Conversation

traines-source
Copy link
Contributor

Some improvements for the UI, without changing too much (see public-transport/transitous#789). This is not perfect yet, consider it a WIP.

  • many small CSS, some JS tweaks
  • some backports from prima-mobile
  • improve error handling, resolves UI error handling #647
  • add URL state management for stops and trips (while I think one could have used SvelteKit Routing, I've opted for pushState like in prima-mobile, which means less refactoring and easier web server configuration)

TODO:

  • annoying bug in the AdressTypeahead Combobox on mobile, where if you select an entry, you accidentally click other buttons (Arrival/Departure/Wheelchair beneath...) Didn't yet manage to fix that...
  • showing map only on demand on mobile
  • URL state mgmt for the itineraries (could be very useful, but also very confusing if returned itineraries change, because we do not have connection ids)

@felixguendling
Copy link
Member

We can also merge UI changes step by step in multiple PRs :)
Makes it easier to understand what's going on.

@traines-source traines-source marked this pull request as ready for review January 19, 2025 00:19
@traines-source
Copy link
Contributor Author

Then have a look :) I might also squash some commits, then you can merge without squashing everything to keep a better/more detailed history.

} = $props();
</script>

<div class="m-4 text-red-600"><div class="min-w-0">{e}</div></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="m-4 text-red-600"><div class="min-w-0">{e}</div></div>
<div class="m-4 text-destructive"><div class="min-w-0">{e}</div></div>

or maybe introduce a error theme dependent error color?

@felixguendling felixguendling merged commit 945ebef into motis-project:master Jan 19, 2025
11 of 12 checks passed
@felixguendling
Copy link
Member

more detailed history

I would not say it has no benefit but IMO it's not worth the time invest to rebase and squash. This time is better invested in code improvements, new features, bug fixes, etc. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI error handling
2 participants