-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Mobile) UI improvements #705
(Mobile) UI improvements #705
Conversation
We can also merge UI changes step by step in multiple PRs :) |
e5304b1
to
17a8d8b
Compare
17a8d8b
to
eaa2053
Compare
Then have a look :) I might also squash some commits, then you can merge without squashing everything to keep a better/more detailed history. |
} = $props(); | ||
</script> | ||
|
||
<div class="m-4 text-red-600"><div class="min-w-0">{e}</div></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div class="m-4 text-red-600"><div class="min-w-0">{e}</div></div> | |
<div class="m-4 text-destructive"><div class="min-w-0">{e}</div></div> |
or maybe introduce a error theme dependent error color?
I would not say it has no benefit but IMO it's not worth the time invest to rebase and squash. This time is better invested in code improvements, new features, bug fixes, etc. :) |
Some improvements for the UI, without changing too much (see public-transport/transitous#789). This is not perfect yet, consider it a WIP.
pushState
like in prima-mobile, which means less refactoring and easier web server configuration)TODO: