Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(krew-ui-svelte): authentication #247

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

feat(krew-ui-svelte): authentication #247

wants to merge 9 commits into from

Conversation

cassshh
Copy link
Member

@cassshh cassshh commented Jul 22, 2021

No description provided.

@cassshh cassshh self-assigned this Jul 22, 2021
@cassshh
Copy link
Member Author

cassshh commented Jul 25, 2021 •
edited
Loading

Interesting how the build fails - build error - when this piece of code isn't even in the codebase of this branch...
There is no reference to it (because it doesn't exist), and then complains how it doesn't exist.

Error during bundle: Error: /home/runner/work/krew-workspace/krew-workspace/libs/api-client/src/lib/services/base.service.ts(71,19): semantic error TS2304: Cannot find name 'ResponseError'.

@cassshh cassshh mentioned this pull request Jul 25, 2021
Merged
@cassshh cassshh changed the title feat(svelte): authentication feat(krew-ui-svelte): authentication Jul 25, 2021
@cassshh cassshh temporarily deployed to Preview Channels July 26, 2021 15:09 Inactive
@cassshh cassshh temporarily deployed to Preview Channels July 26, 2021 15:09 Inactive
@cassshh cassshh temporarily deployed to Preview Channels July 26, 2021 15:09 Inactive
@github-actions
Copy link

github-actions bot commented Jul 26, 2021 •
edited
Loading

Visit the preview URL for this PR (updated for commit 26bdf03):

https://m4m-krew-svelte-dev--krew-ui-svelte-pr-247-rggpm8z9.web.app

(expires Fri, 22 Oct 2021 11:32:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@cassshh cassshh temporarily deployed to Preview Channels October 15, 2021 10:51 Inactive
@cassshh cassshh temporarily deployed to Preview Channels October 15, 2021 10:51 Inactive
@cassshh cassshh temporarily deployed to Preview Channels October 15, 2021 10:51 Inactive
@cassshh cassshh temporarily deployed to Preview Channels October 15, 2021 10:51 Inactive
@cassshh cassshh temporarily deployed to Preview Channels October 15, 2021 11:31 Inactive
@cassshh cassshh temporarily deployed to Preview Channels October 15, 2021 11:31 Inactive
@cassshh cassshh temporarily deployed to Preview Channels October 15, 2021 11:31 Inactive
@cassshh cassshh temporarily deployed to Preview Channels October 15, 2021 11:31 Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschilling mschilling Awaiting requested review from mschilling mschilling will be requested when the pull request is marked ready for review mschilling is a code owner

@jstrating jstrating Awaiting requested review from jstrating jstrating will be requested when the pull request is marked ready for review jstrating is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@cassshh cassshh

Labels
app: krew-ui-svelte
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cassshh