Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move TrajectoryExecutionManager::clear() to private (backport #3226) #3238

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 12, 2025

Description

previously discussed here #3198 (comment)

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3226 done by [Mergify](https://mergify.com).

* move TrajectoryExecutionManager::clear() to private

Signed-off-by: Dongya Jiang <[email protected]>

* Apply suggestions from code review

Co-authored-by: Robert Haschke <[email protected]>

---------

Signed-off-by: Dongya Jiang <[email protected]>
Co-authored-by: Robert Haschke <[email protected]>
(cherry picked from commit 3ec75ab)
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.18%. Comparing base (dfbf1d9) to head (db20f1e).
Report is 1 commits behind head on jazzy.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3238      +/-   ##
==========================================
+ Coverage   44.18%   44.18%   +0.01%     
==========================================
  Files         698      698              
  Lines       61588    61585       -3     
  Branches     7459     7459              
==========================================
  Hits        27207    27207              
+ Misses      34213    34210       -3     
  Partials      168      168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit 689e2b2 into jazzy Jan 12, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/jazzy/pr-3226 branch January 12, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants