Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stomp: Fix passing different types to std::min in cost_functions.hpp (backport #3244) #3245

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 14, 2025

Description

std::min supports comparing scalar of the same type. Depending on the specific platform or compiler, values.cols() return type may not be compatible with long, so explicitly casting ensure that std::min compiles fine on any platform.

Specifically, I had encountered a compilation problem with this when compiling moveit with MSVC 2019.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3244 done by [Mergify](https://mergify.com).

@sea-bass sea-bass requested a review from JafarAbdi January 14, 2025 16:56
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.55%. Comparing base (b1c45fd) to head (643190e).
Report is 1 commits behind head on jazzy.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3245      +/-   ##
==========================================
+ Coverage   44.18%   44.55%   +0.38%     
==========================================
  Files         698      698              
  Lines       61587    61607      +20     
  Branches     7460     7461       +1     
==========================================
+ Hits        27205    27442     +237     
+ Misses      34215    33997     -218     
- Partials      167      168       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit 65b5532 into jazzy Jan 14, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/jazzy/pr-3244 branch January 14, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants